fix: bug in guttertooltip when tooltipsFollowsMouse set to false
#5217
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5217 +/- ##
==========================================
+ Coverage 87.22% 87.24% +0.01%
==========================================
Files 565 565
Lines 45253 45283 +30
Branches 6927 6928 +1
==========================================
+ Hits 39471 39505 +34
+ Misses 5782 5778 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
akoreman
changed the title
tooltipsFollowsMousetooltipsFollowsMouse set to false
src/layer/lines.js
Outdated
| @@ -42,6 +42,15 @@ class Lines { | |||
| get(index) { | |||
| return this.cells[index]; | |||
| } | |||
|
|
|||
| getCellAtRow(row) { | |||
| for (var i = 0; i < this.getLength(); i++){ | |||
There was a problem hiding this comment.
this could be a binary search right? or maybe something faster
There was a problem hiding this comment.
changed the implementation of the search
There was a problem hiding this comment.
implementation is changed to not use any search anymore
src/mouse/mouse_event.js
Outdated
| * @return {Number} 'row' within the gutter. | ||
| */ | ||
| getGutterRow() { | ||
| var documentRow = this.editor.renderer.screenToTextCoordinates(this.clientX, this.clientY).row; |
There was a problem hiding this comment.
Might be better to use this.getDocumentPosition().row here
There was a problem hiding this comment.
ah yeah, good catch, changed
Issue #, if available: NA
Fixes a bug where an error is thrown when hovering over the gutter with
tooltipsFollowsMouse == trueand scrolled. Additionally, addstooltipsFollowsMouseto kitchen-sink to make it easier to test this option.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.