Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getDisplayIndentGuides() call fails since v1.17.0 #5228

Closed
exsilium opened this issue Jun 29, 2023 · 1 comment
Closed

getDisplayIndentGuides() call fails since v1.17.0 #5228

exsilium opened this issue Jun 29, 2023 · 1 comment

Comments

@exsilium
Copy link

Describe the bug

With the es6 class refactoring it seems that getDisplayIndentGuides fails as the renderer function cannot be found: this.renderer.getDisplayIndentGuides is not a function

Virtual renderer function name is in singular form and missing an s: https://github.com/ajaxorg/ace/blame/bc93f987f929453c4f99b7070ad4cdc394578afb/src/virtual_renderer.js#L465

Expected Behavior

getDisplayIndentGuides should return the option value (boolean)

Current Behavior

getDisplayIndentGuides is not working as the renderer function is not found.

Reproduction Steps

Use the VirtualRenderer API call as described in: https://ace.c9.io/api/classes/Ace.VirtualRenderer.html#getDisplayIndentGuides

Possible Solution

Fix the virtual renderer function name to be in plural form.

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

v1.17.0 / Chrome, Safari / MacOS / Nordic

@whazor
Copy link
Contributor

whazor commented Jul 3, 2023

Merged, will be released in next version.

@whazor whazor closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants