Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting line skips multiple line on mobile device. #5245

Closed
deadlyjack opened this issue Jul 7, 2023 · 3 comments
Closed

Deleting line skips multiple line on mobile device. #5245

deadlyjack opened this issue Jul 7, 2023 · 3 comments

Comments

@deadlyjack
Copy link

deadlyjack commented Jul 7, 2023

Describe the bug

Opened kitchen sink page in Google chrome android to check out newest ace build. Added multiple (any mode) lines and tap and hold back button, jt started deleting the characters backwards correctly but when comes to start of line sometime it decide to skip to multiple lines. It works fine till last build release on 17th March 2023.

Expected Behavior

When tapping and holding back button it should not skip the line when cursor it ast the start of line.

Current Behavior

When tapping and holding back button it skips to multiple line when cursor it ast the start of line.

Record_2023-07-07-16-37-31.mp4

Reproduction Steps

  1. Open kitchen sink any mode in Google chrome android with any android device and any soft keyboard e.g. Gboard or SwiftKey Keyboard.
  2. Add multiple lines say 10 lines.
  3. Tap and hold back button. It starts deleting characters backwards.
  4. When the cursor reaches to start of the line it either skips or delete the line.

Possible Solution

Role back to build released on 17th March 2023

Additional Information/Context

No response

Ace Version / Browser / OS / Keyboard layout

Ace version: Latest,
Browser: Google chrome,
Keyboard: SwiftKey keyboard (qwerty)

@akoreman
Copy link
Contributor

akoreman commented Jul 7, 2023

thanks for opening this issue, I can indeed reproduce the issue on my Android device. Given that you say it works fine with the version released on 17th of March 2023 (v1.16.0), the PR that might have caused this regression is #5087. I'll take a look to see if I can figure out what caused this, for the time being you can continue using v.1.16.0.

@akoreman
Copy link
Contributor

PR which caused this regression has been reverted, Ace 1.23.3 no longer has this bug.

@deadlyjack
Copy link
Author

Thanks for fixing it. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants