Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcut for voting #507

Open
SkaveRat opened this issue Oct 14, 2020 · 3 comments
Open

Keyboard shortcut for voting #507

SkaveRat opened this issue Oct 14, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@SkaveRat
Copy link

I would like to vote on segments, but by the time I have grabbed to mouse and moved the cursor, the popup is already gone.

It would be really useful to have a shortcut on the keyboard to vote for the previous segment.

Ideal would be voting on the last segment, as this would remove the need to "jump up and quickly vote" before the popup disappears

@ajayyy ajayyy added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 15, 2020
@Torey-Clark
Copy link

I've started work on this in a fork but I'm having trouble finding the functions for voting on segments to call from the listener.

@ajayyy
Copy link
Owner

ajayyy commented Mar 23, 2021

@Torey-Clark You'll probably want to call the functions in lastSkipNotice, prepAction(). One thing to remember is that a skip notice can be for multiple segments, if there were multiple in a row. So, maybe the keyboard shortcut should only work if there is one segment?

@SameenAhnaf
Copy link

This issue should be closed in favor of #634.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants