Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support channel trailers #58

Closed
ajayyy opened this issue Aug 2, 2019 · 6 comments · Fixed by #1070
Closed

Support channel trailers #58

ajayyy opened this issue Aug 2, 2019 · 6 comments · Fixed by #1070
Assignees
@mchangrh

Comments

@ajayyy
Copy link
Owner

ajayyy commented Aug 2, 2019

No description provided.

@NDevTK
Copy link
Contributor

NDevTK commented Aug 4, 2019

Is this because of the url?

@ajayyy
Copy link
Owner Author

ajayyy commented Aug 4, 2019

Somehow a url would have to be extracted from the video frame. The video frame also has a different id, so buttons don't get added

@ajayyy ajayyy added the wontfix This will not be worked on label Aug 12, 2019
@NDevTK
Copy link
Contributor

NDevTK commented Aug 13, 2019

Why is this "wontfix"?

@NDevTK
Copy link
Contributor

NDevTK commented Aug 13, 2019 •
edited

Added support anyway

@NDevTK NDevTK mentioned this issue Aug 13, 2019
Closed
@ajayyy ajayyy removed the wontfix This will not be worked on label Aug 28, 2019
@ajayyy ajayyy self-assigned this Aug 28, 2019
@NDevTK NDevTK mentioned this issue Jan 11, 2020
Closed
@ajayyy ajayyy removed their assignment Jan 25, 2020
@NDevTK
Copy link
Contributor

NDevTK commented Feb 10, 2020

Failed on this multiple times

@ajayyy ajayyy mentioned this issue Sep 7, 2020
Closed
@mchangrh
Copy link
Contributor

.take

@mchangrh mchangrh mentioned this issue Nov 30, 2021
Merged
11 tasks
@EatVanced EatVanced mentioned this issue Aug 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchangrh mchangrh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect segments on channel trailers mchangrh/SponsorBlock
3 participants
@ajayyy @mchangrh @NDevTK