-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "tabs" permission #87
Comments
Does this interfere with content scripts running in tabs that aren't the active tab. If not, then yes, that's a great idea to switch. If you are up to it, feel free to make a PR :) |
No, content scripts continue running even if the tab is not active. However, the patch will be rather large because this extension
It all needs to be rewrtten with |
activeTab only seems to work when certain actions are taken and until the user navigates to a different origin. |
Yes, but only for pages that you explicitly envoke the extension on via |
activeTab tracking would only affect places where its been invoked |
I think Tab messaging should still work |
Exactly.
Yes, when you click the extension icon you trigger that pageAction and it can query the currently active tab to display the relevant info. |
So are people going to click a pageAction every time they visit youtube |
No, you trigger pageAction when you open the popup by clicking the extension icon. You use pageAction only to figure out what the current tab is to populate the popup with the proper info (if you have multiple pages open with multiple YouTube videos).
They are controlled by content scripts. Since videos are either on This way, if you open a page |
"when you open the popup by clicking the extension icon" so you do have to or it will not be in effect at the moment even submitting a video not just skipping you dont need to use the popup The content script running on the host website is isolated from youtube.com by the iframe and should not be able to control it https://discourse.mozilla.org/t/activetab-permission-does-not-include-iframes-in-current-tab/29084 |
Hmm, this would require a significant rewrite after thinking about it. At the moment background.js is communicating with the content scripts to tell them when a new video is loaded. This would have to be changed to the content scripts using the on hashed changed function (which is probably a better way anyway). Then, everything can be handled by the content script except for actions invoked by the popup. The popup could save a variable right after being opened of the current tab and use that to communicate any time a button clicked (unless I'm misunderstanding). If the plan to make the popup be only for global settings, then the active tab permission won't even be needed. |
I think the best way to solve this is just to make the popup not interact with the tabs at all and just act as a status page (showing how much you have contributed) and a global settings page. |
@ajayyy have you seen my message? I think the problem is valid |
I'm not sure what your question is.
Yes, it would because (currently) the extension uses a lot of
We should be asking a question "what is the best UI for the user" and not "what is easy to implement". The problem is, the first question is much harder than the second one. |
@bershanskiy I was trying to tell you about a problem if you want to use the URL, title, favicon url that you get with the extra permission you will need a action from the user which in an iframe may not be possible Im not sure why you even need activeTab messaging still works anyway |
Made a PR as this seems simple to add: #90 |
I meant that you do not need |
Is sponsor submission really necessary for embeds anyway? Only skipping is needed I'd think. |
Well I think activeTab will not be needed as the URL of a tab is not needed only the video id |
Summary
Currently, users are warned that extension can "Read your browsing history", but I believe you can remove this warning by using
"activeTab"
permission instead of"tabs"
permission.Details
Currently, the extension requires
"tabs"
permission which creates a rather offputting warning "Read your browsing history" (according to this table). This permission is necessary to populateurl
,title
, andfavIconUrl
properties ofTab
objects, which you never use in the scripts. I think, you use it only to infer the current tab to populate the popup interface. Instead, Chrome has"activeTab"
permission that provides this information and does not display any warning message on install.Switching to
"activeTab"
would require a small patch, not just removing"tabs"
from the manifest. If you are interested, I can prepare this patch and make a PR.The text was updated successfully, but these errors were encountered: