Jumping to directories results in error status in fish shell

[cole-h]

The recent _ZO_ECHO changes made fish shell return an error status after jumping to any directory (see the below screenshot). This doesn't affect functionality, but is certainly annoying and wrong behavior, considering it didn't behave like this before.

(I've verified the issue is unrelated to direnv, to assuage any concerns)

Bisected to:

f4cd1159c5419ece11b1d0147c23dba1c7579edc is the first bad commit
commit f4cd1159c5419ece11b1d0147c23dba1c7579edc
Author: Ajeet D'Souza <98ajeet@gmail.com>
Date:   Sun Mar 15 17:44:23 2020 +0530

    Add $_ZO_ECHO to echo match before navigating

 src/subcommand/init.rs | 26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

Disclaimer: this may be present in other shells, but I only use fish.

[ajeetdsouza]

The error happens due to the and [ -n _ZL_ECHO] statement, resulting in an error code when the variable isn't set.

[ajeetdsouza]

Fixed in 146e570. Thanks for pointing this out!

[cole-h]

Thanks, works perfectly! Hopefully you cut a new release soon, so those using the Nixpkgs package won't have to deal with that annoying (but cosmetic) issue for much longer... ;)

[ajeetdsouza]

There's still a few kinks to iron out with the exit codes, but I'm working on it!

[ajeetdsouza]

@cole-h, could you check that the latest commit works as expected for you?

[cole-h]

Works fine for me: still no error status!