Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name of workdir? #11

Open
floer32 opened this issue Jan 6, 2017 · 3 comments
Open

Change name of workdir? #11

floer32 opened this issue Jan 6, 2017 · 3 comments

Comments

@floer32
Copy link
Contributor

floer32 commented Jan 6, 2017

Following on my mistake in #10, with the interpretation that even though I made a dumb mistake, it could be made more obvious in the future.

I would prefer the workdir made by hatchery to be called build_hatchery. Here were my thoughts that lead to this:

  • in .hatchery.work, .work seems like an extension and doesn't follow Python conventions for separating words. .hatchery_work seems just as obvious for purpose but without deviating from other conventions
  • I don't think there is a compelling reason to make this a hidden directory. hatchery.work or hatchery_work seems equally easy to understand, yet does not require any special thought regarding ls etc. Overall it seems like a directory users should be fully aware of, not one that is hidden from them. This is a judgment call... some tools, like tox, prefer to hide the working directory -- its work dir is .tox. But Gradle uses build, node.js uses node_modules ... Anyway this contributed to my mistake in Straightforward option to preserve workdir, or files from it? #10 and could confuse other users in the future, not just exactly in the Straightforward option to preserve workdir, or files from it? #10 case but in other cases where they might miss the hidden dir.
  • build is what Gradle calls its working directory. Why not call hatchery's directory something that fits well with that? build_hatchery?
@floer32
Copy link
Contributor Author

floer32 commented Jan 6, 2017

Whatever decision you like, I can make the PR. If you do not like changing the default directory name, can I submit a PR to allow it to be configurable?

@ajk8
Copy link
Owner

ajk8 commented Jan 6, 2017

I think regardless of the default, it should be configurable. So why don't we start there?

@floer32
Copy link
Contributor Author

floer32 commented Jan 6, 2017

That makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants