Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debye huckel #15

Open
TensorDuck opened this issue Jul 12, 2016 · 4 comments
Open

debye huckel #15

TensorDuck opened this issue Jul 12, 2016 · 4 comments

Comments

@TensorDuck
Copy link
Collaborator

When I try model_builder to source a parameters folder for the awsem package, I end up getting an error. It looks like it's looking for a debye huckel parameters in a file that doesn't have that heading. Is that a typo, or are there updated parameter files for including debye huckel?

Eitherway, a propose a solution: set this up so that if during the source step, it doesn't find the parameters, it won't try to parameterize them later. I can implement this quickly.

@ajkluber
Copy link
Owner

The electrostatic interactions that Min-Yeh has added are on the amylometer branch of AWSEM:
https://github.com/adavtyan/awsemmd/tree/amylometer

Debye Huckel section is on this line.

@ajkluber
Copy link
Owner

For AWSEM parameters I think we should have options to source parameters from a file or use hardcoded defaults. Sourcing would only be necessary for parameters that may change, such as the Debye-Huckel screening length.

The AwsemModel class currently doesn't output its own fix_backbone_coeff.dat (I think) but it should. I will double check this.

@TensorDuck
Copy link
Collaborator Author

Ah okay. It looks like the awsem has different files for different interactions. I think the best way to fix this would be to add checks in our python code that if they don't find an interaction section on sourcing, then the code won't attempt to parameterize the Hamiltonian with those interactions.

I can push these changes with my latest additions to the awsem model if you weren't planning on doing more development work.

@ajkluber
Copy link
Owner

Go ahead and merge when you are ready. I will have to look at this another day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants