-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debye huckel #15
Comments
The electrostatic interactions that Min-Yeh has added are on the amylometer branch of AWSEM: Debye Huckel section is on this line. |
For AWSEM parameters I think we should have options to source parameters from a file or use hardcoded defaults. Sourcing would only be necessary for parameters that may change, such as the Debye-Huckel screening length. The |
Ah okay. It looks like the awsem has different files for different interactions. I think the best way to fix this would be to add checks in our python code that if they don't find an interaction section on sourcing, then the code won't attempt to parameterize the Hamiltonian with those interactions. I can push these changes with my latest additions to the awsem model if you weren't planning on doing more development work. |
Go ahead and merge when you are ready. I will have to look at this another day. |
When I try model_builder to source a parameters folder for the awsem package, I end up getting an error. It looks like it's looking for a debye huckel parameters in a file that doesn't have that heading. Is that a typo, or are there updated parameter files for including debye huckel?
Eitherway, a propose a solution: set this up so that if during the source step, it doesn't find the parameters, it won't try to parameterize them later. I can implement this quickly.
The text was updated successfully, but these errors were encountered: