Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileType magic sequence with offset cannot be recognised #34

Closed
andrea-quartini opened this issue Apr 7, 2024 · 4 comments
Closed

FileType magic sequence with offset cannot be recognised #34

andrea-quartini opened this issue Apr 7, 2024 · 4 comments
Assignees

Comments

@andrea-quartini
Copy link

andrea-quartini commented Apr 7, 2024

If a file type magic sequence have an offset, it cannot be recognised because the offset is applied to the magic byte sequence as well; see for instance Mp4 and M4v file types

Steps to reproduce the behavior:

  1. Into the FileTypeValidatorTests.cs, add a test case for Mp4 file type and file name "test.mp4"
  2. Run the test
  3. Test throws an exception on GetFileType method
AJMitev added a commit that referenced this issue Apr 21, 2024
@AJMitev AJMitev self-assigned this Apr 21, 2024
@AJMitev
Copy link
Owner

AJMitev commented Apr 21, 2024

This will be fixed in next release.

@AJMitev AJMitev closed this as completed Apr 21, 2024
@Chida82
Copy link

Chida82 commented May 6, 2024

with this file not work the validtiaon.

image

we think can add a other array for mp4 quicktime
image

mondoMp4.mp4

@AJMitev
Copy link
Owner

AJMitev commented May 6, 2024

@Chida82 I added this file to the test cases and it worked, can you please specify your problem and maybe provide me with some code example that I can use?

@fedebona
Copy link

fedebona commented May 6, 2024

it works with 4.1.1 after fix of bug #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants