New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NZBGet as download client #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some translations are missing. I haven't had time to review the actual integration yet. Every visible element on the page should be translated (It doesn't apply to error messages in your throws for example)
PR for the doc updates: ajnart/homarr-docs#11 |
Anything else I need to do to get this merged? |
No, but I'd like to have a confirmation from someone else using NZBget that it's working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config file is a no go! Please remove it from the history. Also, please squash your commit messages and reword to ✨ Add NZBGet download client
I was able to connect to a local docker instance of NZBGet. However, I wasn't able to add any newsservers in NZBGet - It told me that my credentials were wrong. |
81d666f
to
2ccc73d
Compare
…marr into 282-nzbget-download-client
I believe I have now removed that commit from the history and squashed with the correct commit message. |
it says 1000+ commits. Did you break it? 😅 |
…marr into 282-nzbget-download-client
Sorry, struggling to completely remove the secret. Thought I had it. Guess not. :( |
|
Config still seems to be in the history. @ajnart can you maybe fix the rebase and squash? I don't want to break anything :D |
Not sure how to fix it |
^ This is the 1st commit message: ✨ Add NZBGet download client Initial prototype WIP: Store & use nzbget user/pass Clean up some lint stuff. Add some translations. WIP: NZBGet queue WIP: Queue progress Cleanup config. Finish nzbget API implementation. Fix linebreaks Finished adding NzbgetHistoryItem type Add more types for nzbget Add NZBGet client and better config error handling ^ This is the commit message ajnart#2: Initial prototype ^ This is the commit message ajnart#3: WIP: Store & use nzbget user/pass ^ This is the commit message ajnart#4: Clean up some lint stuff. Add some translations. ^ This is the commit message ajnart#5: WIP: NZBGet queue ^ This is the commit message ajnart#6: WIP: Queue progress ^ This is the commit message ajnart#7: Cleanup config. Finish nzbget API implementation. ^ This is the commit message ajnart#8: Fix linebreaks # This is the commit message ajnart#9: Finished adding NzbgetHistoryItem type # This is the commit message ajnart#10: Add more types for nzbget
…marr into 282-nzbget-download-client # Conflicts: # src/pages/api/modules/usenet/history.ts # src/pages/api/modules/usenet/index.ts # src/pages/api/modules/usenet/queue.ts
I am not sure what happened, but it doesn't seem to be easily fixable. I created a new PR: #497. Can we use this new one instead and I can delete this old one? |
No, please do not delete this one. I'll close it |
Thank you for contributing to Homarr! So that your Pull Request can be handled effectively, please populate the following fields (delete sections that are not applicable)
Category
Feature
Overview
Issue Number (if applicable)
#282
New Vars (if applicable)
I added a new library that helps in working with the NZBGet api:
"nzbget-api": "0.0.3"
Screenshot (if applicable)