Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property vs. Provider #380

Closed
Vampire opened this issue Feb 10, 2023 · 0 comments · Fixed by #382
Closed

Property vs. Provider #380

Vampire opened this issue Feb 10, 2023 · 0 comments · Fixed by #382

Comments

@Vampire
Copy link
Contributor

Vampire commented Feb 10, 2023

Should org.ajoberstar.grgit.gradle.GrgitServiceExtension#getService really return a Property?
Property is for things that should be configurable.
You probably should just expose it as Provider which is a super-interface of Property.
You might also want to call disallowChanges() and finalizeValueOnRead() on the property after you have set its value to turn it into a cached provider effectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant