Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Showing Rename Files #74

Closed
Scuilion opened this issue Aug 21, 2015 · 7 comments
Closed

Not Showing Rename Files #74

Scuilion opened this issue Aug 21, 2015 · 7 comments
Labels
Milestone

Comments

@Scuilion
Copy link

I can't seem to get grgit.show(id) to display the renamed files.

Running git log -M --summary outputs:


commit 4eec35b7dc52df0e710799c5805be27a928b49a6
Author: kevin <oneal.kevin@gmail.com>
Date:   Fri Aug 21 14:55:21 2015 -0500

    moving

    add read me

 rename originName => newName (100%)

but when I do git.show(id) it does not show any renamed files. What am I missing?

You can see the situation in this repo
Just run `./gradlew checkRename'

@ajoberstar
Copy link
Owner

I don't believe the JGit API provides renamed files in it's status command. If that's true, I wouldn't try to include that in grgit.

@Scuilion
Copy link
Author

I must be misunderstanding something. The CommitDiff object has a rename instance variable, so how would I go about finding the files that have change names in a commit?

@ajoberstar
Copy link
Owner

Oh, I was confusing this with status. I'll have to look at this in more detail to see what's wrong.

@Scuilion
Copy link
Author

Thanks!!

@ajoberstar
Copy link
Owner

Turns out, rename detection is a separate API in JGit. I never had a test for renames so I didn't catch it. Working on a fix right now, and will have it out as 1.4.0-rc.2 pretty quick.

@ajoberstar ajoberstar added the bug label Aug 24, 2015
@ajoberstar ajoberstar added this to the 1.4.0 milestone Aug 24, 2015
@ajoberstar
Copy link
Owner

FYI, just validated this on your test repo. Assuming it's just the one commit with a rename, this should be good to go. I'm going to push out 1.4.0 final now.

@Scuilion
Copy link
Author

Dude, you're the man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants