Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove println from PullOp #91

Closed
jthurne opened this issue Dec 24, 2015 · 1 comment
Closed

Remove println from PullOp #91

jthurne opened this issue Dec 24, 2015 · 1 comment
Labels
Milestone

Comments

@jthurne
Copy link

jthurne commented Dec 24, 2015

Line 97 of PullOp has an unhelpful println. The JGit PullResult class does override toString, but its members (FetchResult, MergeResult, and RebaseResult) do not. When PullOp is executed, something similar to:

org.eclipse.jgit.transport.FetchResult@db188ae6
org.eclipse.jgit.api.RebaseResult@e7b8848a

...is printed to standard out. This is rather annoying when you are trying to use Grgit in a console-based application.

To fix the issue, please delete the println.

@ajoberstar ajoberstar added the bug label Dec 25, 2015
@ajoberstar ajoberstar added this to the 1.5.0 milestone Dec 25, 2015
@ajoberstar
Copy link
Owner

Agreed. I'll put this in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants