-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8 Support #23
Comments
@ajthinking just spent my day adding
I would make a PR , but my code does not follow your project structure at all, and breaks its nice formatting/setup. Ive done quite a bit of method chaining based packages, but you took it to another level. I am always interesting in learning new ways, and if your willing to explain it to me a little over VoIP I can conform the changes, otherwise I plan on branching off from your |
Thanks for taking a look at this 👍 Would love to merge it and assist with any questions. Im available today preferably or weekday evenings ECT |
Got caught up with a project past few days, I'll send you an email to try and setup something next week. |
@pkeogan, could you share the branch? Would love to see it |
Is this actually completed? I can't seem to find a way to add traits using PHPFile. EDIT: I managed to add a trait using $builder->class()->insertStmt((new BuilderFactory())->useTrait('HasRoles')->getNode()) however not using the defined endpoints like there are for implements, extends, etc. I fear I'm not experienced enough to make a PR to add the endpoint though. |
Hi @LukasFreyCZ , thanks for bumping and nice work around. |
Sounds great, thanks! If you need some help, feel free to message/tag me and I'll try my best. :) Even if it's just for testing. |
This package does not yet support PHP 8 features. Would love some help with this
The text was updated successfully, but these errors were encountered: