Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor tab zoom issue #34

Closed
stecchio66 opened this issue Dec 19, 2023 · 4 comments
Closed

Editor tab zoom issue #34

stecchio66 opened this issue Dec 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@stecchio66
Copy link

The zoom level in the Editor tab is not saved and if we close and reopen the meeting editor the zoom level is ever 100%.

@ajtruckle ajtruckle added the bug Something isn't working label Dec 19, 2023
@ajtruckle
Copy link
Owner

The zoom factor is actually saved to the registry correctly:

image

These registry keys are updated immediately whenever you change the zoom factor.


I notice that the WebView2 control defaults to 100% when it is initially created. So there may be a race-condition between the initialization and our subsequent attempt to restore the last used zoom factor setting. But I will continue to investigate and see if I can work out a way to resolve it.

@ajtruckle
Copy link
Owner

@stecchio66
I realise what is going on now.

  • When the WebView2 control is initialised it defaults to a zoom factor of 100%.
  • But, when the meeting editor is being displayed, we update the menu and status bar to match the zoom factor in the WebView2.
  • This value (from WebView2) then gets saved again to the registry.

Once the editor is displayed the above behaviour is fine. It is only during initialisation where the above logic is flawed.

@ajtruckle ajtruckle self-assigned this Dec 20, 2023
@ajtruckle ajtruckle added this to the 24.2.7 milestone Dec 20, 2023
@ajtruckle
Copy link
Owner

@stecchio66
I have put a new beta in the Google Drive folder for you to try. It should behave correctly now. 😊

@stecchio66
Copy link
Author

@ajtruckle
It looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants