Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uri-js by fast-uri #1844

Closed
zekth opened this issue Dec 12, 2021 · 1 comment · Fixed by #1862
Closed

Replace uri-js by fast-uri #1844

zekth opened this issue Dec 12, 2021 · 1 comment · Fixed by #1862

Comments

@zekth
Copy link
Contributor

zekth commented Dec 12, 2021

fast-uri is a fork of uri-js which is rewritten in javascript to focus on performances issues.

What version of Ajv you are you using?

Ajv 8.8.2

What problem do you want to solve?
Speed improvement

What do you think is the correct solution to problem?
As discussed with @epoberezkin , an option can be added to inject fast-uri to replace uri-js to not have a breaking change in the current version

Will you be able to implement it?

Yes

Ref: https://github.com/fastify/fast-uri

@epoberezkin
Copy link
Member

Let's please do in the same way regexp option was added, with URI as default - there should be defined a required interface (type) and fast-url would be dev dependency for tests only.

It would be good if tests are run with it though (doubling the test time...), to see if we can swap in in v9.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants