Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon too clear #6

Closed
Mara-Li opened this issue Apr 1, 2021 · 6 comments
Closed

icon too clear #6

Mara-Li opened this issue Apr 1, 2021 · 6 comments

Comments

@Mara-Li
Copy link

Mara-Li commented Apr 1, 2021

Hello !
This plugin is great, but I cannot see the icon with light mode :
image
(VS dark mode:
image

@j-peeters
Copy link

I have the same problem. Might is be an idea to make the color a variable one that themes like California Coast and Minimal Theme use? I see it's now a hardcoded 'white' Thanks!

@Mara-Li
Copy link
Author

Mara-Li commented Apr 29, 2021

I have the same problem. Might is be an idea to make the color a variable one that themes like California Coast and Minimal Theme use? I see it's now a hardcoded 'white' Thanks!

Hello ! I success to change the image to take the currentcolor (as the other icon). Here is the files :
pdf-to-markdown-plugin.zip

@j-peeters
Copy link

Fabulous @Mara-Li Thanks.
Hopefully the plugin developer will implement your code in the release.
Have you considered doing a Pull request in Github and doing a code change suggestion in it?

@Mara-Li
Copy link
Author

Mara-Li commented Apr 29, 2021

I think i will do that in some hours yes :)

@Mara-Li
Copy link
Author

Mara-Li commented May 2, 2021

So I do the pull request ! #9 (comment)

@aeophie
Copy link

aeophie commented Nov 21, 2021

2021/11/21 This problem still exists

@Mara-Li Mara-Li closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants