Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove svg2png dependency #120

Closed
quanglam2807 opened this issue Jun 4, 2020 · 3 comments
Closed

remove svg2png dependency #120

quanglam2807 opened this issue Jun 4, 2020 · 3 comments
Milestone
v3.0.0

Comments

@quanglam2807
Copy link
Contributor

Is it possible to remove svg2icon from dependencies? I'm using icongen in my Electron app and because svg2icon relies on phantomjs-prebuilt (which is deprecated), it adds 50 MB to the app size.
@akabekobeko
Copy link
Owner

It depends on svg2png, not svg2icon. This npm is required to generate transparent PNGs for various icons from SVG images.

svg2png uses Phantom.js for SVG processing, so finding an alternative may be difficult. However, it's a problem to depend on deprecated npm.

Consider an alternative to svg2png (with phantomjs-prebuilt) as icon-gen.

@akabekobeko akabekobeko changed the title remove svg2icon dependency remove svg2png dependency Jun 4, 2020
@akabekobeko
Copy link
Owner

To support this issue I have started developing a puppeteer-core version of svg2png.

@akabekobeko akabekobeko mentioned this issue Aug 30, 2020
Closed
@akabekobeko
Copy link
Owner

Since this matter will be implemented in #121, close it.

@akabekobeko akabekobeko added this to the v3.0.0 milestone Aug 30, 2020
@muelli muelli mentioned this issue Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
2 participants
@akabekobeko @quanglam2807