Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document, profile and analyze current performance issues #26

Open
3 tasks
akaihola opened this issue Jul 11, 2020 · 2 comments
Open
3 tasks

Document, profile and analyze current performance issues #26

akaihola opened this issue Jul 11, 2020 · 2 comments
Labels
help wanted Extra attention is needed performance Speed or memory usage improvement

Comments

@akaihola
Copy link
Owner

akaihola commented Jul 11, 2020

In #23, @DylanYoung mentions:

Do you use darker in your editor? It takes like 30 seconds to format.

@Mystic-Mirage responds:

I'm a lucky guy and my darker takes 0.5~1.5 seconds. My IDE calls it on every save.

We need to profile darker and find bottlenecks.

Steps remaining:

  • In comments of this GitHub issue, collect remaining performance issues in the current Darker version
  • Create separate GitHub issues for profiling each actual performance issue separately
  • Close this GitHub issue
@akaihola akaihola added this to the 1.1.0 milestone Jul 11, 2020
@akaihola akaihola modified the milestones: 1.1.0, 1.2.0 Aug 6, 2020
@akaihola akaihola modified the milestones: 1.2.0, 1.3.0 Aug 19, 2020
@akaihola
Copy link
Owner Author

@DylanYoung,

Are you still using Darker in your editor? Have you upgraded all the way up to Darker 1.2.1? Do you still have the performance problems you mentioned in #23?

@akaihola akaihola modified the milestones: 1.3.0, 1.3.1, 1.4.0 Sep 4, 2021
@akaihola akaihola added the performance Speed or memory usage improvement label Sep 24, 2021
@akaihola akaihola mentioned this issue Oct 30, 2021
9 tasks
@akaihola
Copy link
Owner Author

@DylanYoung, we have some performance improvements coming up. You could install Darker from the rogalski/darker@jobs branch and use the --jobs=0 argument (zero causes it to use one job per core) and see if that makes it faster for you.

In any case I think it's still a good idea for us to do profiling for some real-world use cases. I'm keeping this open and assigning to a future milestone.

@akaihola akaihola modified the milestones: 1.4.0, 1.4.1 Oct 31, 2021
@akaihola akaihola modified the milestones: 1.4.1, 1.5.0 Feb 10, 2022
@akaihola akaihola modified the milestones: 1.5.0, 1.6.0 Feb 24, 2022
@akaihola akaihola modified the milestones: 1.6.0, 1.6.1, 1.7.1 Dec 19, 2022
@akaihola akaihola modified the milestones: 1.7.1, 1.7.2 Feb 19, 2023
@akaihola akaihola modified the milestones: Darker 1.7.2, Darker 1.8.1 Mar 26, 2023
@akaihola akaihola added the help wanted Extra attention is needed label Mar 28, 2024
@akaihola akaihola changed the title Profile performance issues Document, profile and analyze current performance issues Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed performance Speed or memory usage improvement
Projects
Development

No branches or pull requests

1 participant