Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for using flynt to convert old string literal formatting to f-strings #266

Closed
jedie opened this issue Jan 30, 2022 · 1 comment · Fixed by #308
Closed

No support for using flynt to convert old string literal formatting to f-strings #266

jedie opened this issue Jan 30, 2022 · 1 comment · Fixed by #308
Assignees
@akaihola
Labels
enhancement New feature or request
Projects
Akaihola's Open source work
Milestone
Darker 1.7.0

Comments

@jedie
Copy link
Contributor

jedie commented Jan 30, 2022

https://github.com/ikamensh/flynt is a great tool. Think it's nice if darker includes this.
@akaihola akaihola self-assigned this Feb 2, 2022
@akaihola akaihola added the enhancement New feature or request label Feb 2, 2022
@akaihola akaihola added this to To do in Akaihola's Open source work via automation Feb 2, 2022
@akaihola akaihola added this to the 1.5.0 milestone Feb 2, 2022
@akaihola
Copy link
Owner

akaihola commented Feb 2, 2022

Great idea! It would be a good addition to Black and isort. Let's see how it fits in – it was a bit tricky to get isort in since it can change the order of lines, but that shouldn't be an issue here. It's more that we should be careful about in which order different tools are applied.

This was referenced Feb 22, 2022
Open
Merged
@akaihola akaihola modified the milestones: 1.5.0, 1.6.0 Feb 24, 2022
@akaihola akaihola changed the title Apply flynt to convert old string literal formatting to f-strings No support for using flynt to convert old string literal formatting to f-strings Apr 6, 2022
This was referenced Aug 27, 2022
Merged
Merged
@akaihola akaihola modified the milestones: 1.6.0, 1.6.1, 1.7.0 Dec 19, 2022
Akaihola's Open source work automation moved this from To do to Done Jan 22, 2023
@akaihola akaihola mentioned this issue Mar 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akaihola akaihola

Labels
enhancement New feature or request
Projects
No open projects
Akaihola's Open source work
  
Done
Milestone
Darker 1.7.0
Development

Successfully merging a pull request may close this issue.

Add conversion to f-strings using flynt akaihola/darker
2 participants
@akaihola @jedie