Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes saved doesn't take into account if link destination file was already linked #20

Open
chadnetzer opened this issue Jul 3, 2018 · 0 comments

Comments

@chadnetzer
Copy link
Collaborator

The bytes saved calculation doesn't take into account whether the destination file is already hardlinked, which makes the result overly optimistic. If a destination file is already hardlinked, it shouldn't count towards the bytes saved in did_hardlink().

If/when the stat_info data saved to file_hashes is kept up to date after the link() operation, we could use it to properly calculate the amount of bytes saved (basically when a link destination file has a link count of 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant