Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify dry-run tests in hardlink_files() #27

Open
chadnetzer opened this issue Jul 4, 2018 · 0 comments
Open

Simplify dry-run tests in hardlink_files() #27

chadnetzer opened this issue Jul 4, 2018 · 0 comments

Comments

@chadnetzer
Copy link
Collaborator

Rather than having multiple levels of "if not options.dry-run" checks in hardlink_files(), intertwined with tricky system code and error handling, I think it's much easier to simply perform the dry-run check once at the top, and skip over all the system code and try/except chains. It also makes this fairly critical code section safer to maintain, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant