Module update doesn't trigger

[bitonio]

Hello,

When updating an Akamai CLI module (here eaa) the cli command responds with an "already up-to-date".

The issue happened on a Mac running macOS Catalina 10.15.7, akamai cli 1.1.5 and git version 2.24.1 (Apple Git-126).
This machine runs cli-eaa version 0.2.6 (corresponding commit aecd515fa18e1d200797555f446f9c016e895b8f), and the user is willing to upgrade to 0.2.7 (commit 1c166df4ff9480b9f23fce40f8a4886796bad527). See cli-eaa commits in master branch.

% AKAMAI_LOG=trace akamai update eaa
TRACE[0000] Command found: /Users/androcho/.akamai-cli/src/cli-eaa/bin/akamai-eaa
Attempting to update "eaa" command...
TRACE[0000] Searching for package repo
TRACE[0000] Repo found: /Users/androcho/.akamai-cli/src/cli-eaa
TRACE[0000] Fetching from remote: origin
TRACE[0000] Using ref: refs/remotes/origin/master
TRACE[0000] HEAD is the same as the remote: aecd515fa18e1d200797555f446f9c016e895b8f (old) vs aecd515fa18e1d200797555f446f9c016e895b8f (new)
Attempting to update "eaa" command...... [OK]

command "eaa" already up-to-date

Investigating a little bit further, git status in the ~/.akamai-cli/src/cli-eaa directory seems to consider this is the latest.
Changing directory and executing the following fixed the problem:

% git fetch origin && git pull

And we can confirm it is updated:

%  akamai eaa version
0.2.7

Thanks

[lukaszczerpak]

Might be related to src-d/go-git#1143 as we do shallow clone when installing from git and then on update we ignore "object not found" error:

	err = w.Pull(&git.PullOptions{RemoteName: git.DefaultRemoteName})
	if err != nil && err.Error() != "already up-to-date" && err.Error() != "object not found" {
		log.Tracef("Fetch error: %s", err.Error())
		akamai.StopSpinnerFail()
		return cli.NewExitError(color.RedString("Unable to fetch updates (%s)", err.Error()), 1)
	}

I will try to fix it.

UPDATE:
I've tested with go-git v5 and the same issue manifested itself. There is related ticket opened already: go-git/go-git#207

[lukaszczerpak]

PR: #115

[lkowalsk-akamai-com]

Hi @bitonio , this issue should be fixed now. Please try with latest release and close the ticket.