Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpulse.js code review #1

Closed
cvazac opened this issue May 6, 2015 · 2 comments
Closed

mpulse.js code review #1

cvazac opened this issue May 6, 2015 · 2 comments

Comments

@cvazac
Copy link

cvazac commented May 6, 2015

line 102, should we attach to onreadystatechange if typeof callback === "function"?
line 177, make sure Date is on window
line 273, typo "lenth"
line 580, if sessionID can be 0, then sessionID != null
line 586, should TODOs ship?
line 633, typo Stars
line 662: in stopTimer and sendTimer should degenerate case return something non-zero, maybe -1?
line 863, in subscribe, maybe ensure typeof callback === function
line 904, do test hooks ship?

@nicjansma
Copy link
Contributor

Awesome, fixes in cbd21fb.

line 177, make sure Date is on window

Date is available on the root scope in NodeJS (not just window), so I just did an existence check.

line 586, should TODOs ship?

Fixing those depend on the JavaScript API collector changes on the schedule.

line 904, do test hooks ship?

I think so, I don't think it'll necessarily hurt. We could possibly build w/out that code block in Grunt.

@nicjansma
Copy link
Contributor

All feedback was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants