Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configのtestを正規表現からglobパターンに変更する #21

Closed
akameco opened this issue Oct 9, 2017 · 1 comment
Closed

configのtestを正規表現からglobパターンに変更する #21

akameco opened this issue Oct 9, 2017 · 1 comment

Comments

@akameco
Copy link
Owner

akameco commented Oct 9, 2017 •
edited
Loading

正規表現は複雑で難しい。

https://github.com/sindresorhus/globby を使う。

以下のような指定が可能になる。

test: ['**/*.js', '!**/*.test.js']

stringorstring[]を指定可能にする。
@akameco
Copy link
Owner Author

akameco commented Oct 9, 2017

が、後方互換を保つために、lodash.isRegexpを使い正規表現を共存可能にする。

型的には、以下のようになる。

type TestOption = string | string[] | RegExp

This was referenced Nov 5, 2017
Closed
Merged
@akameco akameco closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akameco