Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginq\Context の名前 #32

Closed
akanehara opened this issue Jun 13, 2013 · 3 comments
Closed

Ginq\Context の名前 #32

akanehara opened this issue Jun 13, 2013 · 3 comments

Comments

@akanehara
Copy link
Owner

https://github.com/akanehara/ginq/tree/feature/ginq-context

feature/ginq-context ブランチの

  • Ginq\Context
  • Ginq\OrderedContext
  • Ginq\GroupingContext

を、それぞれ

  • Ginq\Stream
  • Ginq\OrderedStream
  • Ginq\GroupingStream

にリネームするのはどうかという提案。

@akanehara akanehara mentioned this issue Jun 13, 2013
@akanehara
Copy link
Owner Author

Stream は一般名すぎるという懸念。

@akanehara
Copy link
Owner Author

  • Ginq\Ginq
  • Ginq\OrderedGinq
  • Ginq\GroupingGinq

と命名したうえでトップレベルの Ginq.php を

require_once __DIR__ . "/Ginq/autoload.php";

class Ginq extends Ginq\Ginq { }

とすれば、autoload.php を使う方法でも require を使う方法でも見かけ上同じクラス名になるので混乱が少ないのではないか、というアイディア。

@akanehara
Copy link
Owner Author

GroupingOrdering に統一。

  • Ginq\Ginq
  • Ginq\OrderedGinq
  • Ginq\GroupingGinq

で決着?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant