Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJavaAssemblyException Doesn't Show Stack Trace #10

Closed
T-Spoon opened this issue Mar 28, 2017 · 2 comments
Closed

RxJavaAssemblyException Doesn't Show Stack Trace #10

T-Spoon opened this issue Mar 28, 2017 · 2 comments

Comments

@T-Spoon
Copy link

T-Spoon commented Mar 28, 2017

I noticed some differences in between RxJavaAssemblyException and RxJava1's AssemblyStackTraceException, namely that the the current implementation doesn't pass the stacktrace as a message to super here.

This makes it somewhat difficult to track call sites of streams (without having a debugger attached all the time, or adding some custom logger implementation to specifically log these types of exceptionsusing the find method)

Is this by design? Maybe for clarity when dealing with many chained exceptions?

You also mentioned in the readme that the format is up for discussion - does this mean we'll see support for this in the main RxJava2 repo at some point?

Happy to submit a PR if there's any work needed here (maybe some flags to set what level of logging a user would like e.g. SHOW_ALL_STACKTRACES, SHOW_LAST_STACKTRACE, HIDE_ALL_STACKTRACES).

@akarnokd
Copy link
Owner

Is this by design?

The v2 design was primary for debugging sessions but I guess the stacktrace could go into the message part instead.

does this mean we'll see support for this in the main RxJava2 repo at some point?

The problem with the v1 version is that different people imagine different structure. To avoid arguing, v2 doesn't have this in RxJava proper but I have a version I can work with in this repo.

(maybe some flags to set what level of logging a user would like e.g. SHOW_ALL_STACKTRACES, SHOW_LAST_STACKTRACE, HIDE_ALL_STACKTRACES)

As mentioned, many people want many features and structure. I encourage you to roll your own based on this repo and you can make it as you see fit.

@T-Spoon
Copy link
Author

T-Spoon commented Apr 1, 2017

Ah, thanks for the info!

I took your advice and created a small library to suit my needs a little better: https://github.com/T-Spoon/Traceur

@T-Spoon T-Spoon closed this as completed Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants