You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed some differences in between RxJavaAssemblyException and RxJava1's AssemblyStackTraceException, namely that the the current implementation doesn't pass the stacktrace as a message to super here.
This makes it somewhat difficult to track call sites of streams (without having a debugger attached all the time, or adding some custom logger implementation to specifically log these types of exceptionsusing the find method)
Is this by design? Maybe for clarity when dealing with many chained exceptions?
You also mentioned in the readme that the format is up for discussion - does this mean we'll see support for this in the main RxJava2 repo at some point?
Happy to submit a PR if there's any work needed here (maybe some flags to set what level of logging a user would like e.g. SHOW_ALL_STACKTRACES, SHOW_LAST_STACKTRACE, HIDE_ALL_STACKTRACES).
The text was updated successfully, but these errors were encountered:
The v2 design was primary for debugging sessions but I guess the stacktrace could go into the message part instead.
does this mean we'll see support for this in the main RxJava2 repo at some point?
The problem with the v1 version is that different people imagine different structure. To avoid arguing, v2 doesn't have this in RxJava proper but I have a version I can work with in this repo.
(maybe some flags to set what level of logging a user would like e.g. SHOW_ALL_STACKTRACES, SHOW_LAST_STACKTRACE, HIDE_ALL_STACKTRACES)
As mentioned, many people want many features and structure. I encourage you to roll your own based on this repo and you can make it as you see fit.
I noticed some differences in between
RxJavaAssemblyException
and RxJava1'sAssemblyStackTraceException
, namely that the the current implementation doesn't pass the stacktrace as a message to super here.This makes it somewhat difficult to track call sites of streams (without having a debugger attached all the time, or adding some custom logger implementation to specifically log these types of exceptionsusing the
find
method)Is this by design? Maybe for clarity when dealing with many chained exceptions?
You also mentioned in the readme that the format is up for discussion - does this mean we'll see support for this in the main RxJava2 repo at some point?
Happy to submit a PR if there's any work needed here (maybe some flags to set what level of logging a user would like e.g.
SHOW_ALL_STACKTRACES
,SHOW_LAST_STACKTRACE
,HIDE_ALL_STACKTRACES
).The text was updated successfully, but these errors were encountered: