fix: use from address as string to allow certs signed with ledger #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troian
force-pushed
the
gencert-ledger
branch
3 times, most recently
from
7180eea
to
d622788
Compare
fixes issus when jsonparser in ledger cosmos-app not liking bech address sent as data in binary format if test or file keyring used it will allow to decode old private keys for the mTLS cert fixes akash-network/support#22 Signed-off-by: Artur Troian <troian.ap@gmail.com>
troian
added a commit
that referenced
this pull request
Apr 17, 2023
) fixes issus when jsonparser in ledger cosmos-app not liking bech address sent as data in binary format if test or file keyring used it will allow to decode old private keys for the mTLS cert fixes akash-network/support#22 Signed-off-by: Artur Troian <troian.ap@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issus when jsonparser in ledger cosmos-app
not liking bech address sent as data in binary format if test or file keyring used it will allow to decode old private keys for the mTLS cert
fixes akash-network/support#22