Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files removed from repository are still being installed from cache #44

Closed
borysiasty opened this issue Jul 11, 2017 · 4 comments · Fixed by #108
Closed

Files removed from repository are still being installed from cache #44

borysiasty opened this issue Jul 11, 2017 · 4 comments · Fixed by #108

Comments

@borysiasty
Copy link

I removed some svgs from a repository, pressed Reload Repositories and Reinstall. The removed files are still present in both ~/.qgis2/resource_sharing and ~/QGIS/Resource Sharing directories

@havatv
Copy link
Collaborator

havatv commented Feb 22, 2020

Thanks for reporting, @borysiasty.
What is the result if you first Uninstall and then Install?

Would users always want local files to be deleted when they have been removed from a repository?
At least for scripts (R and Python Processing), files are stored in their standard location in the local file system, sharing room with user scripts.

@borysiasty
Copy link
Author

Unfortunately I won't find any time soon to prepare a test repo and verify it.

My intention was to allow some svgs get obsolete :) Imagine a repository, where new svgs appear every few months, so it's worth to run reinstall it from time to time. And if the repo maintainer wants to remove one of the svgs for any reason (duplicate, copyright issues, ugly, whatever), I looks odd to me to not let them go. But I don't insist.

It was all about symbols and svgs, placed in separate subdirectories for each repo. If scripts land in a common directory, it's a different story of course.

@havatv
Copy link
Collaborator

havatv commented Feb 23, 2020

Good points, @borysiasty. I will look more into it, but not today...

@havatv
Copy link
Collaborator

havatv commented Apr 11, 2020

@borysiasty, I have looked into this. It turns out that the dulwich library (that we use for git access) currently does not support removal of files (jelmer/dulwich#452).
I have tried a "hack" - removing the collection directory before pulling. See #108
The PR was just merged into master, and is included in the 0.13.1 version that is now on plugins.qgis.org.

It would be great if you could test:

  1. get the new version using one of the following methods:

  2. (re)start QGIS

  3. if necessary, enable the plugin in the plugin manager

  4. run the plugin and test if files removed from your repository are still present in the local repository and collection directories

Please re-open if this does not fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants