ReadLecterns flag two issues (signed book only and chat message)

[dramasailor]

Describe the bug
Two observations:

1. When ReadLecterns setflag is turned on, it only allows players to read signed books on lecterns, not book and quill.
2. When ReadLecterns setflag is turned on, players get the "You don't have [player name]'s permission to use that." error message in chat, even if the book opens to be read.

To Reproduce
Steps to reproduce the behavior:
Issue 1 (Only signed books readable)

1. Place a lectern in a claim
2. Place a book and quill with contents written inside on the lectern
3. Ensure that /setflag ReadLecterns is true.
4. Have a non-trusted account attempt to access the book
5. RESULT It gives the error message and the book isn't presented to read

Issue 2 (Chat message appears even if flag is true)

1. Place a lectern in a claim
2. Place a signed book on the lectern
3. Ensure that /setflag ReadLecterns is true.
4. Have a non-trusted account attempt to access the book
5. RESULT It gives the error message in chat and the book is presented to read

Expected behavior

1. Both signed books and book & quill should be readable when the flag is set.
2. If the flag is true and the book can be read, the "You don't have [player name]'s permission to use that." error shouldn't be sent in chat.

Versions:

• GriefPrevention version 16.18
• GPFlags version 5.12.4
• Server version This server is running Pufferfish version git-Pufferfish-11 (MC: 1.19) (Implementing API version 1.19-R0.1-SNAPSHOT) (Git: a593bf6 on HEAD)

[akdukaan]

I noticed issue 2 a while ago on my own server. If I recall correctly, it's caused by a message from GP that GPFlags needs to, but can't, cancel. I don't believe that it's possible for GPFlags to cancel that message from GP in a sensible way. For that reason, I feel like the flag should never have belonged in GPFlags in the first place. It was added before I became the maintainer of the plugin and I've simply kept it in the plugin in case people want to use it anyway. While I personally don't want to spend my time making changes to this flag, I am open to accepting pull requests addressing enhancements with issue 1.

[amongus9000]

Bumping this, @akdukaan, the lectern seems to be readable with the ViewContainers flag on.

[akdukaan]

Bumping this, @akdukaan, the lectern seems to be readable with the ViewContainers flag on.

That's normal. Lecturns are containers.

[akdukaan]

5d1c612 Should have issue 1 fixed now and you can download it from https://jenkins.luminescent.dev/job/GPFlags/. Closing this now as issue 2 isn't fixable.