Modification to work with Hexo3 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hexo.util` and `hexo-file` is undefined. Update to use hexo-util, hexo-fs module.
hexo is undefined here. Update to use `hexo-fs` module. I coundn't correct hexo.theme_dir since I don't have sufficient knowledge about node.js, hexo plugin, etc. I hope you can correct this part.
comment out first line because it's not used in this file. update util, file to require proper module.
|
And the documentation should be updated, too. |
|
Thanks for your contribution. I'll review these changes and merge this PL soon. |
akfish
added a commit
that referenced
this pull request
Mar 21, 2015
akfish
added a commit
that referenced
this pull request
Mar 21, 2015
|
Fixed and published as version 1.0.5. Block tag renamed to Thanks for your contribution again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current hexo-math doesn't work with Hexo3. I modified some part to use correct module (newly introduced in Hexo 3). I couldn't correct
themeDirin Command.js. I just hard coded this part to avoid error. I hope you merge this pull request and correct thethemeDirin Command.js that hexo-math would work well with Hexo3.