Overly broad filtering of jars named /^.*servlet-api.*\.jar$/

[woldie]

isServletApi in org.akhikhl.gretty.JettyConfigurerImpl uses an overly broad matcher to determine if a jar dependency in the war is a servlet-api jar and needs to be filtered from the classpath.

I suspect this logic was put in there to help silly users who mistakenly package their war projects with API spec jars. Fair enough, (although I think you should let those silly users burn rather than rescue them from the fires of their ignorance, ere they will never learn.)

In any case, please just make that matcher do more exact matching to prevent the unfortunate filtering of jars that end in, or contain "servlet-api". Classes from jars with "servlet-api" in the name will throw ClassNotFoundException when running under Gretty. Here's a link to show you all the jars you would be filtering when running under Gretty currently:

http://mvnrepository.com/search?q=servlet-api

Most of those are legit jars to filter, but not all!

We suspect the best solution here would be to create a configurable whitelist of filename regexes that contains the usual suspects. That, or just remove the "servlet-api" filtering altogether.