-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Healthcheck without docker #57
Comments
Hey @SpencerKaiser sorry for the late reply. As it stands right now, the healthcheck just checks if the page returns something (even if that something is some html with error info in it as is your case) which is why I think the healthcheck is passing. So it doesn't quite work as expected and I'm working on fixing that, but in the meantime can you switch to using the checkstring as well. Essentially return some kind of status like |
@AkhileshNS thanks for the response and the clarification! So it doesn't check to see if a I'll definitely go add the |
I'll update the Action to check for status |
Hey sorry it took a while but I've updated the action to check for status code 200 during healthchecks. Hopefully that solves your issue. Closing issue now |
Thanks @AkhileshNS !!! |
I'm using the action for a node.js app that doesn't use docker. The action deploys just fine (despite the README saying you need to use Docker), but it appears that the health check doesn't work... any idea if there's a way to get around that? Here's a link to my project and a link to a build that passed when the healthcheck should have failed and the app should have been rolled back.
The text was updated successfully, but these errors were encountered: