-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX Build reaches dead state #27
Comments
Hi @akielaries, I took a look at this issue. Looks like |
Tests for
On macOS, the tests for the same give these results.
Tests hang for |
Sure thing! Went ahead and assigned the issue to you, feel free to submit a PR and I'll review it |
Hi @akielaries, can you give me some insight on how you chose the test data for |
@sidsbrmnn For the test data it is completely randomized on my end. For some cases I went with larger prime numbers to see if the miller_rabin functions would be able to handle it. Since development is done on Linux machines I was under the impression that my test cases passed as they were supposed to, is one of the cases messing things up? The test cases are located here |
Oh, ok. So... here's the real issue. I tried multiple builds with the macOS replacement for The input to We can go either of the two ways:
What would you prefer? Personally, I'd go with the former approach of adding boundary condition to the function, as it's a library and there's a high chance one might want to use |
This sounds great! I think adding the boundary condition to the function will be the best method. The Miller-Rabin primality test essentially checks for prime numbers given a range of integers, the sequence of these 3 miller-rabin functions is first |
When running the build commands listed in the repository on OSX (regardless of version or architecture), build reaches a dead state/infinite loop when running the GoogleTest suite part of the build process.
The text was updated successfully, but these errors were encountered: