Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The file's icon only shows left half in Windows Terminal #44

Closed
LimbicSys opened this issue Jan 24, 2021 · 2 comments
Closed

The file's icon only shows left half in Windows Terminal #44

LimbicSys opened this issue Jan 24, 2021 · 2 comments

Comments

@LimbicSys
Copy link
Contributor

屏幕截图 2021-01-23 142118
vs code's terminal
屏幕截图 2021-01-23 142142
Windows Terminal

I try to change the code to move the white space right before the filename to the position right after the icon. And then the icon shows properly in Windows Terminal. But I am not sure whether it will have influence on other functions.
图片

@akinsho
Copy link
Owner

akinsho commented Jan 25, 2021

Hi @LimbicSys, tbh I'm not sure entirely what to do here since this works on both linux and macos, or rather I haven't gotten any issues and I run it in both. I think the issue is more related to how specific terminal emulators handle drawing certain characters as your example show it works in vscode's terminal but not in the windows one.

I try to change the code to move the white space right before the filename to the position right after the icon

If you got a PR working for you can you raise it for me to have a look. The plugin keeps track of the size of buffer and it's content so changing the content might cause the size to be miscalculated, but it sounds like you've just reshuffled some spaces. Anyway if you PR what work's for you I'll test it to make sure nothing else breaks and if not will merge it.

@cooperuser
Copy link

Yeah, this is an issue with Windows Terminal itself. I'm pretty sure it is because it draws the characters strictly from left to right, but do not quote me on that. There might be some hacky workarounds like using the non-breaking space character 0x00A0, but I'm not sure that would be applicable here. I was able to use a hack like that when mixing double-width characters and winblend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants