Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: retain the order of pinned buffers when new ones are added #685

Closed
otavioschwanck opened this issue Feb 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@otavioschwanck
Copy link
Contributor

What?

When i pin some buffer, it not always go to the end os pin list (pin list is ordered by bufid). The natural way should be always go to the final of the pin list.

Why?

The current behaviour is not natural and keep messing the order.

@otavioschwanck otavioschwanck added the enhancement New feature or request label Feb 17, 2023
@akinsho
Copy link
Owner

akinsho commented Feb 21, 2023

Happy to take a PR to implement this but I don't think I have time to do this not with all the new issues being opened as 😅

@akinsho akinsho closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2023
@otavioschwanck
Copy link
Contributor Author

@akinsho i want to implement this. Any help where to implement this on the code?

@akinsho akinsho changed the title [Feature Request]: Keep pin order os the buffers [Feature Request]: retain the order of pinned buffers when new ones are added Feb 22, 2023
@akinsho
Copy link
Owner

akinsho commented Feb 22, 2023

This will be fairly difficult probably because it will mean having to re-sort the pinned buffers whenever a new pinned buffer is added/ensuring that no other sorting command causes them to loose their order. Natural feeling or not this maybe a bit tough. let me have a think of a solution. It might need to big a code change for too small a value which won't be acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants