fix(utils): fix utils.is_list #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradsherman
changed the title
|
@akinsho this should fix the problem introduced by the previous PR |
akinsho
previously requested changes
Apr 14, 2023
There was a problem hiding this comment.
Thanks for tracking down the bug and raising the PR @bradsherman I've just left a comment as I think this logic can be simplified greatly
akinsho
dismissed
their stale review
I've pushed a commit which applies the changes I mentioned
|
Sorry I was away from my computer this weekend. That's much nicer - thanks for taking it over the finish line! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#726 Introduced a bug because
utils.is_listneed to be executed in order to return a function that will return a boolean if the object is a list. This broke the tests, now it properly returns aboolean.I ran the tests with the following command I got from the ci workflow yaml.
nvim --headless -u tests/minimal_init.lua -c "PlenaryBustedDirectory tests/ {minimal_init = 'tests/minimal_init.lua', sequential = true}"I also ran the formatter with: