Open mapping opens a second window

[romgrk]

Config:

require'toggleterm'.setup{
  size = 20,
  open_mapping = [[<c-space>]],
  shade_filetypes = {},
  shade_terminals = true,
  -- shading_factor = '<number>' -- the degree by which to darken to terminal colour, default: 1 for dark backgrounds, 3 for light
  start_in_insert = true,
  persist_size = true,
  -- direction = 'vertical' | 'horizontal',
}

After first mapping:

After second mapping:

Can't remember what was the previous time I updated but this started happening just after I updated just now.

[akinsho]

Hi @romgrk, do you have set hidden on in your config? if not this is one known thing that causes this issue. If you do already use that but are still seeing this can you try a minimal config with just this plugin and see if it still causes this issue

[romgrk]

Not reproducible with minimal config. Any idea what kind of issue might be causing this?

[akinsho]

@romgrk do you have an terminal related autocommands? I previously encountered this in #25 I think, the issue there being that that person didn't have set hidden on which meant when the terminal was being hidden it was being disposed of so every time it was triggered it wouldn't find the previous one.

In your screenshots it's appears to be trying to recreate terminal 1 each time, so it mustn't be finding it. Can you try toggling one terminal open, then running require('toggleterm.terminal').get_all() should return the map of all terminals. If it's empty then that would explain why the second toggle is creating a new term but not sure why the terminal wouldn't be being saved on open.

[romgrk]

It's the same terminal, but shown in two separate windows, changes in one are reflected in the other window. I'll debug further later, unless you have any other guesses as to what might be the cause.

Here is the output:

[akinsho]

No nothing off the top of my head other than I think something else must be set somewhere i.e. a vim setting I'm not thinking of or an autocommand, sorry no immediate ideas/suggestions other than the classic binary settings search

[romgrk]

Found it, custom setf terminal was conflicting with toggleterm's filetype.