Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting rows property to < 1 or null crashes the app and tab. #1254

Open
blwsh opened this issue Jun 1, 2018 · 15 comments
Open

Setting rows property to < 1 or null crashes the app and tab. #1254

blwsh opened this issue Jun 1, 2018 · 15 comments

Comments

@blwsh
Copy link

blwsh commented Jun 1, 2018

The app will crash if you set the sliders row property to anything < 1 or null. The row property sometimes needs to be set to 0 so slick doesn't wrap your slide content in a pointless div according to a resolved issue on the slick github repo.

To replicate just add rows: 0 to your settings object.

@silicakes
Copy link

Same here.
I've tried to use rows: 0 in order to avoid the regression caused by adding an extra row div.
The page crashes.

@GioLogist
Copy link

Can confirm, happening for me as well - latest stable version.

@edzjins
Copy link

edzjins commented Jul 31, 2018

Can confirm too, happens on the latest stable version, it's acually unusable for me at this point because of it.

@matenka-andrii
Copy link

Same here. Guys is there some way to fix that behavior?

@webdevpchoi
Copy link

Confirm this issue is still occurring. Has anyone found a fix for this yet? Having a redundant div is driving me bonkers.

@LuisPerez94
Copy link

Confirm this issue is still occurring

@blwsh
Copy link
Author

blwsh commented Jun 24, 2019

1 year old this issue. They grow so fast. If I get a moment I’ll try put in a pull request.

@l3dger
Copy link

l3dger commented Jul 26, 2019

Has a fix for this been released yet?

@samturner3
Copy link

This issue is also blocking solving #1539

We can't set the height to be the same for all sides based on the tallest slide without rows: 0

@partyconfetti
Copy link

Still crashes and took a lot of time to figure out in a big project...

@blwsh
Copy link
Author

blwsh commented Mar 20, 2020

Dw! The world will end soon, we can mark this issue as “low priority”

@TheHacker66
Copy link

We almost defeated covid but we can't have a fixed slider in 2021.. I'll see if I can do it and open a PR.

@vsdmoraes
Copy link

Same here, sometimes crashes, sometimes open a debugger.
Any updates?

@JoeJHoward
Copy link

Same here crashes every time. The issue is also without rows: 0 the slider sets inline-block to slides which adds extra height to the slide. Even with line styles I can't overwrite this. See issue below from original slick repo:

kenwheeler/slick#3581

@adamcharvat
Copy link

Has anyone found a solution here? This is affecting issue kenwheeler/slick#3581 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests