Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependencies #46

Open
pfefferle opened this issue Nov 24, 2023 · 1 comment
Open

Remove Dependencies #46

pfefferle opened this issue Nov 24, 2023 · 1 comment

Comments

@pfefferle
Copy link
Collaborator

I would propose to remove all dependencies to third party plugins like ActivityPub and Friends and to focus on actions/filters, that can be then implemented by the Friends and ActivityPub plugin.

This would make the handling easier and provide a more solid base for others to build on top.

@akirk
Copy link
Owner

akirk commented Nov 24, 2023

When developing this plugin, I tried to do this where possible. It works without either ActivityPub or Friends.

There are some places in the code where it checks for other plugins like this:

$status = make_clickable( $status );
if ( class_exists( '\Activitypub\Mention' ) ) {
	$status = \Activitypub\Mention::the_content( $status );
}

I need to review the code again but I introduced filters that other plugins can use, which I do in the Friends plugin. Do you have specific instances where you see I didn't adhere to this idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants