add newline to A: pseudo header when adding attachment #50
Conversation
The eutil.add_header_line function, used to add the pseudo header, expects a newline terminated string. Otherwise it will remove the RFC defined newline between header and body in the message being composed.
|
Wouldn't it make more sense to fix the surprising behavior of I have a fix for this on my own branch doing exactly that, but haven't gotten around to upstreaming all those: The-Compiler@9390aef |
|
@The-Compiler that also crossed my mind, but I would add the the newline only when it is not already there, because in that case the function would add an extra newline to the body. I made the assumption that, in this code, a header is a newline terminated string, but I agree that your approach absolutely makes sense. |
|
I suppose that could be avoided with a |
|
What's the status of this? It looks like the discussion is inconclusive on whether this should be merged. |
The eutil.add_header_line function, used to add the pseudo header, expects a newline terminated string. Otherwise it will remove the RFC defined newline between header and body in the message being composed.
fixes #49