Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larapoll is open for developement! #13

Closed
akiyamaSM opened this issue Sep 21, 2017 · 2 comments
Closed

Larapoll is open for developement! #13

akiyamaSM opened this issue Sep 21, 2017 · 2 comments

Comments

@akiyamaSM
Copy link
Owner

Its been a long time since I ever contributed to the package, Now I feel that I can be able to add new thing on demande.
So Feel Free to ask for things you may want to see in the next releasse.

@vesper8
Copy link
Contributor

vesper8 commented Oct 15, 2017

hey @akiyamaSM! hadn't really looked at this for a few months and super happy to see the number of commits as almost tripled since i made my fork

looking forward to seeing what you've added. I see you added the hasVoted too. I think my approach might be a bit cleaner and making use of the relationships between models. Check it out?

https://github.com/vesper8/larapoll/commits/master

I had also added a way to prevent duplicates. any chance you could add it as well? check out my commit above

I'll let you know if I have any other ideas! keep it up!

@akiyamaSM
Copy link
Owner Author

Great! Make a PR and I'll merge it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants