Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return warning alert when poll object not found on database #64

Closed
obiefy opened this issue Apr 5, 2019 · 3 comments
Closed

Return warning alert when poll object not found on database #64

obiefy opened this issue Apr 5, 2019 · 3 comments
Labels
help wanted

Comments

@obiefy
Copy link
Contributor

obiefy commented Apr 5, 2019 •
edited
Loading

I found this exception when I am trying to use PollWriter::draw($poll_id) method on a nonexistent poll.
I think it will be good if this method returned a warning alert instead of no results exception.

Screenshot (3)
@akiyamaSM
Copy link
Owner

Its an option, Or to hide it totally. you can provide a PR I'll be happy to merge it.

@obiefy
Copy link
Contributor Author

obiefy commented Apr 6, 2019 •
edited
Loading

I started work on this issue, I think it is a good idea to use type hinting on this method.

@akiyamaSM
Copy link
Owner

Fixed with #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akiyamaSM @obiefy