fix: don't throw if the promise got completed in the meanwhile #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
approved these changes
Feb 21, 2022
| @@ -172,7 +172,7 @@ private final class AkkaNettyGrpcClientGraphStage[I, O]( | |||
| call = null | |||
| } | |||
| if (!matVal.isCompleted) { | |||
| matVal.failure(new AbruptStageTerminationException(this)) | |||
| matVal.tryFailure(new AbruptStageTerminationException(this)) | |||
There was a problem hiding this comment.
I guess we can remove the matVal.isCompleted check now, then?
There was a problem hiding this comment.
Hmm.. 🤔
Does it make sense to try if we know it's completed?
On the other hand removing the check would reduce the LOC, so I can do that if you want. 👍
Should I?
There was a problem hiding this comment.
A matter of taste I suppose - let's leave it like this 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1578.
Switching
failuretotryFailure, because it can happen that the promise gets completed in the meanwhile, in this case we shouldn't throw an exception.