Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to deal with extra clients options #72

Closed
octonato opened this issue Mar 9, 2018 · 2 comments
Closed

Investigate how to deal with extra clients options #72

octonato opened this issue Mar 9, 2018 · 2 comments
Labels
Milestone

Comments

@octonato
Copy link
Member

octonato commented Mar 9, 2018

At client side one may need to tweak how the client should work.

The grpc-java implementation has with methods, e.g.: withCompression, withExecutor, withInterceptors, etc. Those methods are added to the stub and returns a new tweaked stub.

We could have something similar or take an approach similar to Lagom's ServiceCall. To be discussed and analysed.

@raboof
Copy link
Member

raboof commented Mar 9, 2018

For most of those these it seems you'd rarely want to control it on a per-request basis, so it might be fine to have them as a parameter when constructing the client?

@octonato octonato added the client label Mar 9, 2018
@johanandren
Copy link
Member

This was fixed by #201

@raboof raboof added this to the invalid milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants