Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify the protoc version #885

Merged
merged 1 commit into from Mar 24, 2020

Conversation

dotbg
Copy link
Contributor

@dotbg dotbg commented Mar 23, 2020

Fixes #884

@akka-ci
Copy link

akka-ci commented Mar 23, 2020

Thank you for your pull request! After a quick sanity check one of the team will reply with 'OK TO TEST' to kick off our automated validation on Jenkins. This compiles the project, runs the tests, and checks for things like binary compatibility and source code formatting. When two team members have also manually reviewed and (perhaps after asking for some amendments) accepted your contribution, it should be good to be merged.

For more details about our contributing process, check out CONTRIBUTING.md - and feel free to ask!

@raboof
Copy link
Member

raboof commented Mar 24, 2020

OK TO TEST

@raboof raboof merged commit 65bd13d into akka:master Mar 24, 2020
@dotbg dotbg deleted the maven-plugin-fix branch October 22, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maven-plugin uses old protoc-jar version
3 participants