Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name root project 'akka-http-root' #1030

Merged
merged 1 commit into from
Apr 13, 2017
Merged

Name root project 'akka-http-root' #1030

merged 1 commit into from
Apr 13, 2017

Conversation

raboof
Copy link
Member

@raboof raboof commented Apr 13, 2017

Used as default for the sbt prompt, IntelliJ project name, perhaps other things

@raboof
Name root project 'akka-http-root'
511feeb 
Used as default for the sbt prompt, IntelliJ project name, perhaps other things
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Apr 13, 2017
@akka-ci
Copy link

akka-ci commented Apr 13, 2017

Test PASSed.

@2m
Copy link
Member

2m commented Apr 13, 2017

LGTM

jlprat
jlprat approved these changes Apr 13, 2017
View reviewed changes
Copy link
Member

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raboof raboof merged commit d117b19 into master Apr 13, 2017
@raboof raboof deleted the rootProjectName branch April 13, 2017 14:00
@jrudolph
Copy link
Member

👍

@ktoso
Copy link
Member

ktoso commented Apr 13, 2017

Good idea, thanks :)

@aruediger
Copy link
Contributor

👍

tomrf1 pushed a commit to tomrf1/akka-http that referenced this pull request Aug 13, 2017
@raboof @tomrf1
Name root project 'akka-http-root' (akka#1030)
c814fdd 
Used as default for the sbt prompt, IntelliJ project name, perhaps other things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlprat jlprat jlprat approved these changes

Assignees
No one assigned
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@raboof @akka-ci @2m @jrudolph @ktoso @aruediger @jlprat