Refactor Http2 incoming-side stream state machine #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akka-ci
added
validating
|
Test PASSed. |
ktoso
reviewed
Apr 27, 2017
| state: StreamState, | ||
| outlet: Option[BufferedOutlet[ByteString]] | ||
| ) | ||
| override protected def logSource: Class[_] = classOf[Http2ServerDemux] |
ktoso
reviewed
Apr 27, 2017
| @@ -81,14 +78,10 @@ class Http2ServerDemux extends GraphStage[BidiShape[Http2SubStream, FrameEvent, | |||
| BidiShape(substreamIn, frameOut, frameIn, substreamOut) | |||
|
|
|||
| def createLogic(inheritedAttributes: Attributes): GraphStageLogic = | |||
| new GraphStageLogic(shape) with GenericOutletSupport with Http2MultiplexerSupport with StageLogging { | |||
| new GraphStageLogic(shape) with Http2MultiplexerSupport with Http2StreamHandling with GenericOutletSupport with StageLogging { | |||
There was a problem hiding this comment.
Good, I like these kinds of splitting up with traits 👍
ktoso
reviewed
Apr 27, 2017
| case object Closed extends IncomingStreamState { | ||
| def handle(event: StreamFrameEvent): IncomingStreamState = receivedUnexpectedFrame(event) | ||
| } | ||
|
|
ktoso
approved these changes
Apr 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's now in its own file and handle StreamFrameEvents depending on the state of a stream.
Refs #1053.