Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response contains NotFound status if FormData exceeds size limit of withSizeLimit directive #1341

Closed
ayurchuk opened this issue Aug 9, 2017 · 2 comments
Closed

Response contains NotFound status if FormData exceeds size limit of withSizeLimit directive #1341

ayurchuk opened this issue Aug 9, 2017 · 2 comments
Labels
3 - in progress Someone is working on this ticket t:routing Issues related to the routing DSL t:server Issues related to the HTTP server
Milestone
10.0.11

Comments

@ayurchuk
Copy link

ayurchuk commented Aug 9, 2017 •
edited
Loading

FormFieldDirectives doesn't handle EntityStreamSizeException.
As a result withSizeLimit returns NotFound if the size of FormData exceeds a limit.
But if the request contains too large Entity then BadRequest is returned.

There is a fix for this issue: #1337
@ayurchuk ayurchuk mentioned this issue Aug 9, 2017
Merged
@jrudolph
Copy link
Member

I see this as somewhat of a duplicate of #962. I see that it might make sense to handle EntityStreamSizeException specially as you propose in #1337.

@jrudolph jrudolph added 3 - in progress Someone is working on this ticket t:routing Issues related to the routing DSL t:server Issues related to the HTTP server labels Aug 15, 2017
@ayurchuk
Copy link
Author

Issue has been fixed and merged in #1337

@raboof raboof added this to the 10.0.11 milestone Sep 26, 2017
@raboof raboof closed this as completed Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - in progress Someone is working on this ticket t:routing Issues related to the routing DSL t:server Issues related to the HTTP server
Projects
None yet
Milestone
10.0.11
Development

No branches or pull requests
3 participants
@jrudolph @raboof @ayurchuk