New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response contains NotFound status if FormData exceeds size limit of withSizeLimit directive #1341

Closed
ayurchuk opened this Issue Aug 9, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@ayurchuk
Contributor

ayurchuk commented Aug 9, 2017

FormFieldDirectives doesn't handle EntityStreamSizeException.
As a result withSizeLimit returns NotFound if the size of FormData exceeds a limit.
But if the request contains too large Entity then BadRequest is returned.

There is a fix for this issue: #1337

ayurchuk added a commit to ayurchuk/akka-http that referenced this issue Aug 9, 2017

akka#1341 Return BadRequest when size of FormData exceeds limit of `w…
…ithSizeLimit` directive

Handle EntityStreamSizeException in FormFieldDirectives.
As a result withSizeLimit returns BadRequest if the size of FormData exceeds a limit.
It works in the same way for too large Entity.

ayurchuk added a commit to ayurchuk/akka-http that referenced this issue Aug 9, 2017

akka#1341 Return BadRequest when size of FormData exceeds limit of `w…
…ithSizeLimit` directive

Actual behavior:
withSizeLimit in combination with formFieldMap directive responds with NotFound status code when a size of FormData exceeds the limit.

Expected behavior:
The combination of these directives should respond with BadRequest in a case of too large FormData, as it is implemented for too large Entity.

In order to fix this, handling of EntityStreamSizeException was added to FormFieldDirectives.

Handle EntityStreamSizeException in FormFieldDirectives.
As a result withSizeLimit returns BadRequest if the size of FormData exceeds a limit.
It works in the same way for too large Entity.

ayurchuk added a commit to ayurchuk/akka-http that referenced this issue Aug 9, 2017

akka#1341 Return BadRequest when size of FormData exceeds limit of `w…
…ithSizeLimit` directive

Actual behavior:
withSizeLimit in combination with formFieldMap directive responds with NotFound status code when a size of FormData exceeds the limit.

Expected behavior:
The combination of these directives should respond with BadRequest in a case of too large FormData, as it is implemented for too large Entity.

In order to fix this, handling of EntityStreamSizeException was added to FormFieldDirectives.
@jrudolph

This comment has been minimized.

Show comment
Hide comment
@jrudolph

jrudolph Aug 15, 2017

Member

I see this as somewhat of a duplicate of #962. I see that it might make sense to handle EntityStreamSizeException specially as you propose in #1337.

Member

jrudolph commented Aug 15, 2017

I see this as somewhat of a duplicate of #962. I see that it might make sense to handle EntityStreamSizeException specially as you propose in #1337.

ayurchuk added a commit to ayurchuk/akka-http that referenced this issue Aug 28, 2017

akka#1341 Return BadRequest when size of FormData exceeds limit of `w…
…ithSizeLimit` directive

Actual behavior:
withSizeLimit in combination with formFieldMap directive responds with NotFound status code when a size of FormData exceeds the limit.

Expected behavior:
The combination of these directives should respond with BadRequest in a case of too large FormData, as it is implemented for too large Entity.

In order to fix this, handling of EntityStreamSizeException was added to FormFieldDirectives.

ayurchuk added a commit to ayurchuk/akka-http that referenced this issue Aug 28, 2017

akka#1341 Return BadRequest when size of FormData exceeds limit of `w…
…ithSizeLimit` directive

Actual behavior:
withSizeLimit in combination with formFieldMap directive responds with NotFound status code when a size of FormData exceeds the limit.

Expected behavior:
The combination of these directives should respond with BadRequest in a case of too large FormData, as it is implemented for too large Entity.

In order to fix this, handling of EntityStreamSizeException was added to FormFieldDirectives.
@ayurchuk

This comment has been minimized.

Show comment
Hide comment
@ayurchuk

ayurchuk Sep 26, 2017

Contributor

Issue has been fixed and merged in #1337

Contributor

ayurchuk commented Sep 26, 2017

Issue has been fixed and merged in #1337

@raboof raboof added this to the 10.0.11 milestone Sep 26, 2017

@raboof raboof closed this Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment